vscode: Make TerminalLink compatible to VS Code 1.64.2
#11522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the out-dated definition of the TerminalLink interface with the current class that also provides a constructor. In the course of fixing this, I discovered eclipse-theia#11521. So it looks like Theia doesn't support registering TerminalLinkProvider at the moment. Anyway, making TerminalLink compatible to VS Code will help anyway, but only really gets effective once eclipse-theia#11521 is fixed. Fixes eclipse-theia#11507 Contributed on behalf of STMicroelectronics. Change-Id: If183c73b8152770c4c9062355f92143f7e201e53 Signed-off-by: Philip Langer <[email protected]>
planger
force-pushed
the
planger/issues/11507
branch
from
0f56515 to
7beb5ea
Compare
vince-fugnitto
added
terminal
|
@vince-fugnitto Sure, we can wait, if you prefer. Since terminal link providers of plugins that register a provider will never be called by Theia, I guess it doesn't make a difference whether |
|
@planger I'd prefer if we link the two yes, it gives a better representation that it is actually supported and they are tied together. |
|
Closing this to wait for an actual implementation of the |
|
This change is now part of #11552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Replaces the out-dated definition of the
TerminalLinkinterface with the current class that also provides a constructor.In the course of fixing this, I discovered #11521. So it looks like Theia doesn't support registering
TerminalLinkProviderat the moment. Anyway, makingTerminalLinkcompatible to VS Code will help anyway, but only really gets effective once #11521 is fixed.Fixes #11507
Contributed on behalf of STMicroelectronics.
How to test
There is nothing really to test as
TerminalLinkisn't used in the Theia code base anyway and now its definition is at least equivalent to how it is defined in VS Code1.64.2.Also I tested that this change makes the check in the
vscode-theia-comparatorhappy.Review checklist
Reminder for reviewers