Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure download directory exists #11486

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Ensure download directory exists #11486

merged 1 commit into from
Jul 29, 2022

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Jul 29, 2022 •
edited
Loading

What it does

Fixes: #11485

How to test

  1. Delete your user storage directory (~/.theia/)
  2. Start the application and install a plugin from Open VSX
  3. Installation should succeed.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the open-vsx issues related to the open-vsx registry label Jul 29, 2022
@colin-grant-work colin-grant-work force-pushed the bugfix/failure-to-install-from-vsx branch from c4649f7 to 46fd1b6 Compare July 29, 2022 14:12
vince-fugnitto
vince-fugnitto approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes fix the regression 👍
I am now able to install extensions with a clean setup (no ~/.theia/extensions initially).

@colin-grant-work colin-grant-work merged commit 0c0f8c7 into eclipse-theia:master Jul 29, 2022
@colin-grant-work colin-grant-work deleted the bugfix/failure-to-install-from-vsx branch July 29, 2022 14:39
@colin-grant-work colin-grant-work added this to the 1.29.0 milestone Aug 2, 2022
federicobozzini pushed a commit to ARMmbed/theia that referenced this pull request May 5, 2023
@colin-grant-work @federicobozzini
Ensure download directory exists (eclipse-theia#11486)
a5365aa
erezmus pushed a commit to ARMmbed/theia that referenced this pull request May 11, 2023
@colin-grant-work @erezmus
Ensure download directory exists (eclipse-theia#11486)
7955f53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
open-vsx issues related to the open-vsx registry
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.

vsx-registry: unable to install plugins if ~/.theia/extensions does not exist
2 participants
@colin-grant-work @vince-fugnitto