Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: add no-unreachable eslint rule #11476

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request adds the no-unreachable eslint rule as an error.

This rule disallows unreachable code after return, throw, continue, and break statements.

image

How to test

  • the CI checks should be green
  • adding unreachable code should produce an error.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit adds the `no-unreachable` eslint rule as an error.
The rule will prevent unreachable code in the codebase.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added quality issues related to code and application quality linting issues related to linting labels Jul 28, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • CI is green
  • ESLint complains about unreachable code in the editor

@vince-fugnitto vince-fugnitto merged commit 56190e6 into master Jul 28, 2022
@vince-fugnitto vince-fugnitto deleted the vf/eslint-unreachable branch July 28, 2022 18:50
@github-actions github-actions bot added this to the 1.29.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting issues related to linting quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants