Fix: Display failed when text document content provider return empty string ('') #11474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Jul 28, 2022
msujew
reviewed
Jul 28, 2022
There was a problem hiding this comment.
It seems like my changes lead to the ECA check failing (they were authored using [email protected], which isn't covered by the ECA). Do you mind squashing the commits so that only your original email appears in the commit log?
@msujew I amend the commit email. |
…string Signed-off-by: hyy <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
There was a problem hiding this comment.
@hyy215 please take a look at the build errors, The throw is also unreachable so we can safely remove it.
Co-authored-by: Vincent Fugnitto <[email protected]>
msujew
reviewed
Jul 28, 2022
Signed-off-by: hyy <[email protected]>
msujew
approved these changes
Jul 28, 2022
vince-fugnitto
added
plug-in system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix：Display failed when text document content provider return empty string ('')
How to test
Review checklist
Reminder for reviewers