Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siw: update find in folder menu to only apply for folders #11456

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #3614.

Inspired by #11453, the pull-request updates the Find in Folder menu item for the explorer to only apply to folders and not files. The changes also include registering a keybinding for the command similarly to vscode.

How to test

  1. start the application with a workspace.
  2. open the explorer.
  3. with a folder selected, confirm that find in folder is present in the context-menu and triggering it will populate the search-in-workspace with the appropriate include section.
  4. confirm with multiple folders selected that step 3 works.
  5. confirm that the keybinding works for the command (shift+alt+f)
  6. confirm with a file selected the find in folder does not appear.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the `find in folder` menu to only apply for folders and not files.
The commit also registers a keybinding for the command.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added navigator issues related to the navigator/explorer search in workspace issues related to the search-in-workspace labels Jul 22, 2022
@msujew msujew self-requested a review July 25, 2022 20:15
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit d1e588a into master Jul 26, 2022
@vince-fugnitto vince-fugnitto deleted the vf/find-in-folder branch July 26, 2022 12:28
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer search in workspace issues related to the search-in-workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu action "Find in Folder..." should not be visible for files
2 participants