monaco: fix activeItem handling
#11438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/vsx-registry/src/browser/vsx-extensions-contribution.ts
Outdated
Show resolved
Hide resolved
vince-fugnitto
force-pushed
the
vf/fix-activeItem
branch
from
13e0688 to
109c83e
Compare
The commit fixes an issue where the `activeItem` was not being respected when calling the `showQuickPick` API. The `activeItem` is now respected and the item will be defaulted in the list and highlighted. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/fix-activeItem
branch
from
109c83e to
2a72512
Compare
colin-grant-work
approved these changes
Jul 18, 2022
msujew
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10454.
Fixes #11436.
The pull-request fixes an issue where the
activeItemwas not being respected when calling theshowQuickPickAPI.The
activeItemis now respected and the item will be defaulted in the list and highlighted. The issue was that we were setting theactiveItembefore theitemslist had been set which resulted in nothing being set.How to test
Preferences: File Icon Themewill default to and highlight the active file icon theme when the menu is openedPreferences: Color Themewill default to and highlight the active color theme when the menu is openedInstall Another Version...will default to and highlight thecurrentversionConfigure Display Languagehighlights the current language (regression test)Preferences: Open Themeis triggered from a keybinding #11436 is fixed.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]