Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original labels for monaco commands #11434

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 18, 2022

What it does

Closes #11349

Monaco stores its original labels in an alias property that we can use to set the original label.

How to test

  1. Change your locale to another language than English
  2. Open an editor view
  3. Open the command palette and search for a command contributed by monaco (such as Add cursor below)
  4. The command should appear with its translated title and its original name below in the command palette

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Jul 18, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes fix the bug 👍

@msujew msujew added the monaco issues related to monaco label Jul 18, 2022
@msujew msujew merged commit 78b7f95 into master Jul 18, 2022
@msujew msujew deleted the msujew/fix-monaco-original-labels branch July 18, 2022 13:55
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nls: original label not displayed for commands contributed by monaco
2 participants