Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide all selected URIs for command execution #11433

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Provide all selected URIs for command execution #11433

merged 1 commit into from
Jul 15, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 15, 2022

What it does

Closes #10198

See also #11424. Somehow I managed again to completely destroy the git history by rebasing...

VSCode provides in addition to the URI of the last selected file in the explorer also an array of all selected URIs. This change aligns Theia to this behavior.

How to test

  1. Install the test extension (source)
  2. Select multiple/one file in the file explorer
  3. Use the Show URIs command in the context menu of the file explorer
  4. It should show the same output as if installed in vscode, including all selected URIs

Review checklist

Reminder for reviewers

@msujew msujew requested a review from colin-grant-work July 15, 2022 20:52
colin-grant-work
colin-grant-work approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and aligns more exactly with VSCode's behavior 👍

@msujew msujew added the vscode issues related to VSCode compatibility label Jul 15, 2022
@msujew msujew merged commit f4572e3 into master Jul 15, 2022
@msujew msujew deleted the msujew/provide-all-uris branch July 15, 2022 21:36
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msujew @colin-grant-work