monaco: update tokenization
#11416
Merged
monaco: update tokenization
#11416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Looks good to me! Opening and scrolling through a large, single line file is about as fast as in vscode without any noticeable regressions. It still hangs the UI (I tested it with the extension.js of the vscode.typescript-language-features extension) for 2-3 seconds, but it does the same in vscode, so I don't think there's anything we can improve on.
The commit updates the monaco tokenization with the following improvements for performance: - skip tokenizations for lines exceeding the limit. - return partial tokenizations for line which take too long to tokenize. The fix ultimately resolves an issue which prevented large files from being opened and the application hanging. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/tokenization-update
branch
from
5387999 to
5a272eb
Compare
|
I made a minor change following offline discussions with @colin-grant-work to return partial results (similarly to vscode) for work done before the time limit was reached. |
colin-grant-work
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The commit updates the monaco tokenization with the following improvements for performance:
The fix ultimately resolves an issue which prevented large files from being opened and the application hanging.
How to test
theiaas a workspace~/.vscode/extensions/eamodio.gitlens-12.1.2/dist/gitlens.js)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]