Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up lsof on macOS #11411

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

FinnChen
Copy link
Contributor

What it does

Theia may spawn too many lsof processes on macOS. This PR will speed up lsof by add more options.

VSCode also handled this issue. microsoft/vscode#78438

How to test

  • Run Theia on macOS.
  • Open terminal and run long running tasks.
  • Watch the processes.

image

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added OS/Mac issues related to Mac OS process issues related to the process extension labels Jul 12, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

I confirmed that the email [email protected] is not found when using the ECA look up tool.

@FinnChen
Copy link
Contributor Author

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

I confirmed that the email [email protected] is not found when using the ECA look up tool.

I repushed the code with my signed email.

@FinnChen FinnChen requested a review from vince-fugnitto July 13, 2022 09:10
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍
The updates are aligned with work vscode did in the past to avoid unnecessary work by lsof (microsoft/vscode@c7e72d7 amd microsoft/vscode@2b20162);

@vince-fugnitto vince-fugnitto merged commit 2784ecd into eclipse-theia:master Jul 13, 2022
@FinnChen FinnChen deleted the finn/lsof branch July 21, 2022 14:28
@vince-fugnitto vince-fugnitto added this to the 1.28.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Mac issues related to Mac OS process issues related to the process extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants