Fix for #11401 #11409
Merged
Fix for #11401 #11409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Baltasar Belyavsky <[email protected]>
msujew
reviewed
Jul 12, 2022
There was a problem hiding this comment.
@bbelyavsky-ti Given that the changes require a special setup to test manually, do you mind addressing Vince's comment and add a unit test for this? While the changes look reasonable, it'd be great to confirm that it does work as intended before merging.
vince-fugnitto
added
filesystem
Signed-off-by: Baltasar Belyavsky <[email protected]>
Signed-off-by: Baltasar Belyavsky <[email protected]>
colin-grant-work
approved these changes
Jul 13, 2022
|
Thank you for your input, @colin-grant-work, @msujew, @vince-fugnitto. Would one of you be able to merge this PR? I do not have the required permissions. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Baltasar Belyavsky [email protected]
What it does
Fixes: #11401
How to test
Unit tests implemented and included in this PR. In addition to that, in our own implementation of a Theia-based IDE, I've tested the fix using our implementation of a C++ error-parser which contributes markers to the Problems view when a C++ project is built. This bug was causing all markers on a C++ project scope to be cleared every time any file is deleted within the project. For more context - the class MarkerManager uses the FileChangesEvent.contains() method to clear markers associated with any deleted files. The FileChangesEvent.contains() intends to check if a file's ancestor directory has been deleted, as can be seen in the code comments. But this bug is causing the opposite effect, causing markers to be cleared on a project when any contained file is deleted.
Review checklist
Reminder for reviewers