Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markers: update problem-widget rendering #11408

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request updates the rendering present in the problems-widget to align more closely with vscode:

  • only adds the source and no longer the owner (no more _generated_diagnostic_collection_name_ when source is undefined).
  • updates the location to include ln and col for readability.
  • updates to use localizations.

image

How to test

  1. start the application and open a json file (ex: settings.json or launch.json)
  2. produce error markers
  3. the rendering of the nodes should behave properly

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the rendering of the problems-widget to more closely
align with vscode:

- removes `owner` from being displayed (only displays `source`).
- updates the line and column number to align with vscode.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added markers issues related to problem markers problems issues related to the problems widget labels Jul 11, 2022
@vince-fugnitto vince-fugnitto self-assigned this Jul 11, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • The behavior has been aligned to vscode
  • The location marker is localized correctly

@vince-fugnitto vince-fugnitto merged commit 9e837ae into master Jul 15, 2022
@vince-fugnitto vince-fugnitto deleted the vf/problems-ui-update branch July 15, 2022 22:21
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers issues related to problem markers problems issues related to the problems widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants