handle user cancellation for variables #11406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a variable to throw a cancellation error to notify the variable resolver that the resolution process should be aborted. Remove `checkAllResolved` option from `VariableResolveOptions`.
paul-marechal
force-pushed
the
mp/variable-cancellation
branch
2 times, most recently
from
5580211 to
1ecf161
Compare
paul-marechal
force-pushed
the
mp/variable-cancellation
branch
from
1ecf161 to
75e82fe
Compare
alvsan09
reviewed
Jul 11, 2022
There was a problem hiding this comment.
@paul-marechal ,
it seems to work fine! 👍
As per the code, only a couple of cosmetics as inline comments!!
packages/variable-resolver/src/browser/variable-resolver-service.spec.ts
Outdated
Show resolved
Hide resolved
|
@jfaltermeier regarding your comment I agree that our current components lack something. I think we should address that as a follow-up. |
alvsan09
approved these changes
Jul 11, 2022
vince-fugnitto
added
the
variable-resolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a variable to throw a cancellation error to notify the variable
resolver that the resolution process should be aborted.
Remove
checkAllResolvedoption fromVariableResolveOptions.Closes: #11332
How to test
Download and build the following test project
https://github.com/alvsan09/hello_express
Open the project in theia
From the debug view launch the configuration
Attach to node process,Launch the configuration
Launch BackendLaunch the configuration
Launch FrontendHello Worldmessage.Review checklist
Reminder for reviewers