Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vscode-ripgrep to @vscode/ripgrep #11389

Conversation

Niklas-Dahlquist
Copy link
Contributor

What it does

Fix build issues behind proxies by upgrading vscode-ripgrep. Microsoft is maintaining an own branch of vscode-ripgrep. This PR updates all dependecies to the new name @vscode/ripgrep and upgrades it.

Contributed by STMicroelectronics

Signed-off-by: Niklas DAHLQUIST [email protected]

How to test

Review checklist

Reminder for reviewers

Microsoft is maintaining an own branch of vscode-ripgrep
This PR updates all dependecies to @vscode/ripgrep and upgrades
to a version that supports proxies

Contributed by STMicroelectronics

Signed-off-by: Niklas DAHLQUIST <[email protected]>
@msujew msujew self-requested a review July 6, 2022 11:05
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update. I can confirm that the updated dependency does not introduce any regressions 👍

@JonasHelming JonasHelming merged commit fb5d695 into eclipse-theia:master Jul 6, 2022
@JonasHelming JonasHelming added this to the 1.28.0 milestone Jul 6, 2022
@Niklas-Dahlquist Niklas-Dahlquist deleted the nd-upgrade-vscode-ripgrep branch July 7, 2022 06:40
@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants