Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scm): remove double border #11382

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix(scm): remove double border #11382

merged 1 commit into from
Jun 30, 2022

Conversation

yiliang114
Copy link
Contributor

Signed-off-by: yiliang114 [email protected]

What it does

remove double border

before:
image

after:
image

How to test

  1. start the application
  2. switch source-control activity bar and have a look

Review checklist

Reminder for reviewers

@yiliang114
Copy link
Contributor Author

className theia-scm-commit-container is repeated.

image

@vince-fugnitto vince-fugnitto added the scm issues related to the source control manager label Jun 30, 2022
vince-fugnitto
vince-fugnitto approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I confirmed that it looks good now and the double border is gone.

@vince-fugnitto vince-fugnitto merged commit e509272 into eclipse-theia:master Jun 30, 2022
@vince-fugnitto vince-fugnitto added this to the 1.27.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
scm issues related to the source control manager
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yiliang114 @vince-fugnitto