Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vertical center icons in getting started (#11369) #11370

Merged
merged 1 commit into from
Jun 29, 2022
Merged

vertical center icons in getting started (#11369) #11370

merged 1 commit into from
Jun 29, 2022

Conversation

yiliang114
Copy link
Contributor

Signed-off-by: yiliang114 [email protected]

What it does

Just vertical center icons in getting started.

How to test

  1. Open the browser application.
  2. Use Cmd+Shift+P call out Command Palette.
  3. Enter Getting Started to open Getting Started Tab.
  4. Check icons alignment.

before:
image

after:
image

Review checklist

Reminder for reviewers

colin-grant-work
colin-grant-work approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change achieves its objective and is scoped narrowly to produce no regressions. 👍

@yiliang114
Copy link
Contributor Author

The change achieves its objective and is scoped narrowly to produce no regressions. 👍

Thanks for your review.

@colin-grant-work colin-grant-work merged commit f53f131 into eclipse-theia:master Jun 29, 2022
@vince-fugnitto vince-fugnitto added the getting-started issues related to the getting-started extension label Jun 30, 2022
@vince-fugnitto vince-fugnitto added this to the 1.27.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
getting-started issues related to the getting-started extension
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yiliang114 @colin-grant-work @vince-fugnitto