Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize file save dialog #11367

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Localize file save dialog #11367

merged 1 commit into from
Jun 29, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 29, 2022

What it does

Closes #11361

How to test

  1. Change the locale of Theia
  2. Set the auto save preference to off
  3. Modify a file and try to close it without saving. The dialog should be completely and correctly localized.

Review checklist

Reminder for reviewers

@msujew msujew added dialogs issues related to dialogs localization issues related to localization/internalization/nls labels Jun 29, 2022
@vince-fugnitto vince-fugnitto mentioned this pull request Jun 29, 2022
Merged
1 task
colin-grant-work
colin-grant-work approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog is now correctly localized. 👍

@msujew msujew merged commit 805edd4 into master Jun 29, 2022
@msujew msujew deleted the msujew/localize-save-dialog branch June 29, 2022 17:40
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
dialogs issues related to dialogs localization issues related to localization/internalization/nls
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.

Missing Translations in File Save dialog
2 participants
@msujew @colin-grant-work