keymaps: fix search when keybindings are updated #11366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the keybinding-widget results when keybindings are updated. Previously the update would cause the widget to reset completely and re-render and not respect the search query. Signed-off-by: vince-fugnitto <[email protected]>
colin-grant-work
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #11365.
The pull-request fixes a minor regression from #11102 where the update of keybindings would cause the keyboard shortcuts view from re-rendering but not respecting the search field if a user has a query present. The change preserves the search on update:
kb-preserve-search.mp4
How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]