monaco: fix symbol icons

[vince-fugnitto]

What it does

Fixes: #11357.

The pull-request fixes the symbol icons for multiple views (outline, callhierarchy, treehierarchy) by re-using codicons similarly to vscode. Previously we used svg which were removed from our sources so we defaulted to an incorrect icon.

outline:

call-hierarchy:

How to test

1. start the application
2. open multiple files, for each file opened confirm that the symbols in the outline-view for the file are correct
3. confirm that expanding/collapsing nodes in the outline view correctly display their symbols
4. confirm that the call-hierarchy symbols are correct

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[paul-marechal]

I confirm that the proper icons are now displayed in the outline view!

[colin-grant-work]

The changes update to show the correct symbol icons for each symbol type in call hierarchy, outline, and breadcrumbs. 👍

[kittaakos]

This is great!

Out of curiosity, where's --theia-sprite-y-offset defined? I wanted to understand how it worked but could not find the CSS constant definition. Thanks for the help!

[vince-fugnitto]

Out of curiosity, where's --theia-sprite-y-offset defined?

@kittaakos I'm not quite sure myself, I don't see any reference to it besides the css file I cleaned up. It's likely that it is leftovers (in addition to the css classes) from a previous update towards codicons, or a previous monaco update.

[kittaakos]

It's likely that it is leftovers

Thank you so much for checking <3 I also thought this is/was leftover.