Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SiW result caption renderer #11345

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Update SiW result caption renderer #11345

merged 1 commit into from
Jun 27, 2022

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #11343

How to test

  1. Use the SiW widget.
  2. Confirm that the results are correctly rendered - no repeated or missing characters.
  3. Confirm that the results are rendered in a manner consistent with VSCode's style - no leading ....

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the search in workspace issues related to the search-in-workspace label Jun 24, 2022
vince-fugnitto
vince-fugnitto approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work as expected, and the results are more consistent with the behavior experinced in vscode 👍

@colin-grant-work colin-grant-work merged commit 4061027 into eclipse-theia:master Jun 27, 2022
@colin-grant-work colin-grant-work deleted the feature/siw-no-initial-ellipsis branch June 27, 2022 15:38
@colin-grant-work colin-grant-work added this to the 1.27.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.

Text of SiW widget nodes not consistent with VSCode
2 participants
@colin-grant-work @vince-fugnitto