fix: Omit _All Files_ filter in Electron on Linux #11325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't add an _All Files_ filter, if we are on Linux and no other filter is specified. Otherwise, we run into eclipse-theia#11321 which causes an extension filter `['*']` to hide files without extensions. Once we are on Electron >18, we should be able to add the _All Files_ filter again in all cases, as this Electron bug seems to be resolved in Electron above >18. Fixes eclipse-theia#11321 Change-Id: Iec3120a6260f20b7f0d42c091aa00bde33fa915a Signed-off-by: Philip Langer <[email protected]>
colin-grant-work
approved these changes
Jun 24, 2022
packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: colin-grant-work <[email protected]>
vince-fugnitto
added
electron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Omits adding the All Files filter, if we are on Linux and no other filter is specified. Otherwise, we run into #11321 which causes an extension filter
['*']to hide files without extensions. Once we are on Electron >18, we should be able to add the All Files filter again in all cases, as this Electron bug seems to be resolved in Electron above >18.Fixes #11321
Change-Id: Iec3120a6260f20b7f0d42c091aa00bde33fa915a
Signed-off-by: Philip Langer [email protected]
How to test
We should also ensure that other OSs aren't affected (OSX and Windows), as well as that the All Files filter still shows up when a specific filter is specified. Unfortunately, I could only test the latter myself (when specific filters are specified) but not the former, because I don't have a Windows or OSX machine.
Review checklist
Reminder for reviewers