nsfw: simplify event path resolution #11322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
OS/Windows
1 task
NSFW already works on resolved paths. Our code had the issue of trying to resolve paths on the filesystem when the file was moved or removed, so it was bound to fail to some extend.
paul-marechal
force-pushed
the
mp/windows-fs-watch-path
branch
from
0ca05da to
c9c46b3
Compare
|
Not sure why macOS reports ADDED, ADDED, ADDED instead of ADDED, DELETED, ADDED... |
paul-marechal
force-pushed
the
mp/windows-fs-watch-path
branch
from
3b34d19 to
f8cbc75
Compare
msujew
approved these changes
Jun 23, 2022
packages/filesystem/src/node/nsfw-watcher/nsfw-filesystem-watcher.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSFW already works on resolved paths. Our code had the issue of trying
to resolve paths on the filesystem when the file was moved or removed,
so it was bound to fail to some extend.
Closes #11258
How to test
See new unit test.
Review checklist
Reminder for reviewers