Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: update cursor for custom select-component #11305

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jun 16, 2022

What it does

Playing around with the framework today I noticed that the cursor when interacting with the custom select-component was incorrect, instead we should display a pointer like other applications including vscode.

The commit updates the cursor for our custom select-component when an option is selected.

select-component-cursor.mp4

How to test

  1. start the application using theia as a workspace
  2. open the debug-view, interact with the launch configuration dropdown and confirm the cursor when hovering and selecting options is correct
  3. do the same as step 2 for the preferences-view (which also uses the custom select-component)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Jun 16, 2022
@vince-fugnitto vince-fugnitto requested a review from msujew June 16, 2022 17:23
@vince-fugnitto vince-fugnitto self-assigned this Jun 16, 2022
@colin-grant-work
Copy link
Contributor

In VSCode (and with this code), the cursor for the select itself is not a pointer, and that's a little unexpected. I think I'd expect most things that permit interaction by a 'click' to have the pointer.

@vince-fugnitto
Copy link
Member Author

In VSCode (and with this code), the cursor for the select itself is not a pointer, and that's a little unexpected. I think I'd expect most things that permit interaction by a 'click' to have the pointer.

@colin-grant-work even odder is the fact that vscode displays the pointer for the debug select component but not for the preferences ones for me. I'm fine with adding them for both, any objection @msujew?

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It correctly mirrors the pointer behavior for preferences 👍 Having consistent behavior across preferences and other views (debug, etc.) is fine for me.

The commit updates the cursor for our custom `select-component` when an
option is selected. In order to align with behavior with different
applications including vscode the cursor should be a `pointer`.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto force-pushed the vf/select-component-cursor branch from 67c1001 to 7b3eaa1 Compare June 17, 2022 14:37
Copy link
Contributor

@alvsan09 alvsan09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me !!
I am certainly in favor to offer an consistent experience !! 👍

@vince-fugnitto vince-fugnitto merged commit 8a8f4b3 into master Jun 20, 2022
@vince-fugnitto vince-fugnitto deleted the vf/select-component-cursor branch June 20, 2022 18:11
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants