Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Configure Display Language command #11289

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Update Configure Display Language command #11289

merged 2 commits into from
Jun 21, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 13, 2022

What it does

Updates the UX of the Configure Display Language command to align to VSCode version 1.68 (see changelogs).

VSCode:

image

Theia (new):

image

How to test

  1. Run the Configure Display Language command
  2. Assert that the new functionality (displaying available languages from ovsx) works as it does in vscode
    • Selecting one of the "Available" languages should install it and ask to confirm the language change
    • Selecting one of the "Installed" language should show no regressions

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Jun 13, 2022
@msujew msujew force-pushed the msujew/update-configure-display-language branch 3 times, most recently from 4553660 to 0b537ca Compare June 13, 2022 13:52
@colin-grant-work colin-grant-work self-requested a review June 16, 2022 21:05
colin-grant-work
colin-grant-work reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this worked well for me. A few comments on the code.

packages/monaco/src/browser/monaco-quick-input-service.ts Show resolved Hide resolved
packages/monaco/src/browser/monaco-quick-input-service.ts Outdated Show resolved Hide resolved
packages/vsx-registry/src/browser/vsx-language-quick-pick-service.ts Outdated Show resolved Hide resolved
packages/core/src/browser/i18n/language-quick-pick-service.ts Show resolved Hide resolved
packages/core/src/browser/i18n/language-quick-pick-service.ts Outdated Show resolved Hide resolved
@msujew msujew requested a review from colin-grant-work June 20, 2022 11:25
colin-grant-work
colin-grant-work approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new functionality is working well, and it's nice to have the progress marker 👍

@msujew msujew force-pushed the msujew/update-configure-display-language branch from f826826 to 2dc2f47 Compare June 20, 2022 15:51
@msujew msujew merged commit ce01284 into master Jun 21, 2022
@msujew msujew deleted the msujew/update-configure-display-language branch June 21, 2022 12:29
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 21, 2022
@federicobozzini federicobozzini mentioned this pull request Apr 11, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msujew @colin-grant-work