-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse same DebugSessionWidget for all debug sessions. #11277
Reuse same DebugSessionWidget for all debug sessions. #11277
Conversation
653e943
to
0185277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of removed code :D
Anyway, I couldn't notice any regressions from master and the improved behavior works correctly
- Moving a debug view part to another view container works as expected
- Changing to another debug session (in one container) updates the call stack view (in another container) correctly
- Moved view parts stay where they are supposed to be after reloading the app
A minor thing which also doesn't work on master currently is that switching between debug sessions doesn't update the select component (but correctly updates the debug repl):
This is likely out of scope for this PR, but I just wanted to write it down somewhere.
0185277
to
3be5cf8
Compare
@thegecko, I know that debugging is a topic of interest to ARM. Is the ability to open multiple sessions simultaneously in different areas important to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks good 👍
Thanks for the heads up. At the moment, we don't require support for running multiple debuggers with separate UI panels. In fact it makes my open PR a little simpler (although it will need rewriting). I'll revisit that when this is merged: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tested the debugger still works as expected
What it does
Fixes #9930 by using the same
DebugSessionWidget
for all debug sessions. It removes a fair bit of code that assumes that we will open manyDebugSessionWidget
s, which could break downstream applications that exploit that assumption.How to test
Run Mocha test
configuration, and another on a basic JS file using the dynamic session)DebugSessionWidget
into other view containers, and assert that (3) is still true.DebugSessionWidget
, restart the application.Review checklist
Reminder for reviewers