Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for tab close button #11272

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 8, 2022

What it does

Adds a tooltip/title for the tab close button. Previously it showed the tooltip of the tab, now either "Close" or "Unpin", depending on whether it is closable or pinned.

Also cleans up some className manipulation sorrounding the pin feature.

How to test

  1. Hover over the close/unpin button
  2. Assert that the tooltip is updated correctly based on the state
  3. Assert that the pinning/unpinning feature hasn't experienced any regressions

Review checklist

Reminder for reviewers

@msujew msujew added the quality issues related to code and application quality label Jun 8, 2022
@colin-grant-work colin-grant-work self-requested a review June 8, 2022 16:38
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I confirm that the tooltip is correctly displayed, and there are no visible regressions.

packages/core/src/browser/shell/tab-bars.ts Show resolved Hide resolved
@colin-grant-work colin-grant-work removed their request for review June 8, 2022 19:17
@msujew msujew merged commit 5bfa6dd into master Jun 15, 2022
@msujew msujew deleted the msujew/tooltip-for-tab-close branch June 15, 2022 09:32
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants