Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: set cursor to pointer for active menu items #11223

Merged
merged 1 commit into from
May 31, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The change updates the cursor for active menu items from the default (arrow) to the pointer which aligns with other applications including vscode. I had noticed the issue when testing another pull-request and thought I'd do a quick fix.

How to test

  1. start the application (both browser and electron)
  2. using the main-menu, confirm that active menu items display a cursor
  3. for step 2 confirm that disabled menus do not display a cursor
  4. confirm the same is true context-menus (trees, editors)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the cursor for active menu items so they display a
`pointer` (clickable).

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added ui/ux issues related to user interface / user experience menus issues related to the menu labels May 30, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this change aligns the cursor for menu items to vscode 👍

@vince-fugnitto vince-fugnitto merged commit aebf3fd into master May 31, 2022
@vince-fugnitto vince-fugnitto deleted the vf/menu-cursor branch May 31, 2022 13:18
@github-actions github-actions bot added this to the 1.27.0 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menus issues related to the menu ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants