Fixed Typo

[PrajwalBorkar]

What it does

Closes #11218

How to test

Confirm the description update is correct.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Prajwal Borkar [email protected]

[vince-fugnitto]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

[PrajwalBorkar]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

Should I create account in Eclipse as doc suggests or just signed off line in the commit msg will work?

[vince-fugnitto]

Should I create account in Eclipse as doc suggests or just signed off line in the commit msg will work?

You'll need to follow the docs and create an eclipse account yes.

[PrajwalBorkar]

Should I create account in Eclipse as doc suggests or just signed off line in the commit msg will work?

You'll need to follow the docs and create an eclipse account yes.

Done. But changes not reflected here.

[vince-fugnitto]

@JonasHelming any objection to the authorship email and eca? In the past I don't think we allowed noreply emails:

From 6ab8a14d925a3a48ff07b0e1df94abc8a1f51e5b Mon Sep 17 00:00:00 2001
From: Prajwal Borkar <[email protected]>
Date: Mon, 30 May 2022 22:53:17 +0530
Subject: [PATCH] Update proxy-cli-contribution.ts

---
 packages/core/src/node/request/proxy-cli-contribution.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/core/src/node/request/proxy-cli-contribution.ts b/packages/core/src/node/request/proxy-cli-contribution.ts
index 4b034d4d1478..bde6a864437b 100644
--- a/packages/core/src/node/request/proxy-cli-contribution.ts
+++ b/packages/core/src/node/request/proxy-cli-contribution.ts
@@ -40,7 +40,7 @@ export class ProxyCliContribution implements CliContribution {
             type: 'string'
         });
         conf.option(StrictSSL, {
-            description: 'Detemines whether SSL is strictly set for outgoing requests.',
+            description: 'Determines whether SSL is strictly set for outgoing requests.',
             type: 'boolean'
         });
     }

[JonasHelming]

@PrajwalBorkar Thank you for you first contribution! Please update your commit to origin from the same E-Mail you used for the Eclipse account. It should be your real mail address please. The background for this procedure is the IP check for this open source projects. To enable adopters to use Theia, we need to ensure that all commits to the project are complying with the ECA.

[vince-fugnitto]

@PrajwalBorkar do you still plan on contributing the fix?

[PrajwalBorkar]

@PrajwalBorkar do you still plan on contributing the fix?

I already made the changes. Do I need to do anything now?

[vince-fugnitto]

@PrajwalBorkar as #11222 (comment) mentioned it looks like you are using a noreply email which I don't believe we allow:

From: Prajwal Borkar <[email protected]>

it should be your real mail address please.

[PrajwalBorkar]

@PrajwalBorkar as #11222 (comment) mentioned it looks like you are using a noreply email which I don't believe we allow:

From: Prajwal Borkar <[email protected]>

it should be your real mail address please.

Now how to change that? Should I open new PR instead?

[msujew]

Now how to change that? Should I open new PR instead?

@PrajwalBorkar No need to create a new PR. You can amend your commit using another author, something like this:

git commit --amend --author="John Doe <[email protected]>"

You of course need to change the associated email for the ECA as well.

[PrajwalBorkar]

Now how to change that? Should I open new PR instead?

@PrajwalBorkar No need to create a new PR. You can amend your commit using another author, something like this:

git commit --amend --author="John Doe <[email protected]>"

You of course need to change the associated email for the ECA as well.

Done. Please review for any changes.

[vince-fugnitto]

The changes look good to me, as well as the authorship 👍
Thank you for your first contribution and patience! We look forward to any future contributions.

[randydwhitephotography]

merged