drop support for node 12 #11210
Merged
drop support for node 12 #11210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
force-pushed
the
mp/drop-node-12
branch
from
8c6fad5 to
5c7edfa
Compare
|
Related: #11198 |
paul-marechal
force-pushed
the
mp/drop-node-12
branch
3 times, most recently
from
9eedce5 to
5bce35c
Compare
|
Turns out Node 18.x requires a glibc version greater than what's available on Ubuntu 18.04. |
paul-marechal
force-pushed
the
mp/drop-node-12
branch
2 times, most recently
from
a2bdfe0 to
7322adb
Compare
|
We can probably close #10013 thanks to the changes. |
paul-marechal
force-pushed
the
mp/drop-node-12
branch
2 times, most recently
from
da46468 to
aeb9ab2
Compare
|
Turns out Node 18.x uses I now explicitly set the default hostname to |
paul-marechal
force-pushed
the
mp/drop-node-12
branch
2 times, most recently
from
850c018 to
5b138c2
Compare
|
I dropped trying to test on Node 18, it will require more investigation to get working. |
vince-fugnitto
approved these changes
May 31, 2022
Keep supporting Node 14.x but recommend Node 16.x.
paul-marechal
force-pushed
the
mp/drop-node-12
branch
from
5b138c2 to
2cc3fcf
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep supporting Node 14.x but recommend Node 16.x.
Closes #10013
How to test
Nothing should have changed. Everything should work like before with Node 14 or Node 16.
Review checklist
Reminder for reviewers