Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-11196 Remove dev/debug logoutput from IPCChannel #11197

Merged
merged 1 commit into from
May 25, 2022
Merged

GH-11196 Remove dev/debug logoutput from IPCChannel #11197

merged 1 commit into from
May 25, 2022

Conversation

tortmayr
Copy link
Contributor

Fixes #11196

What it does

Removes an accidental committed debug/dev log messages that pollutes the shared console log.
Fixes #11196

How to test

Message should no longer appear in the console log.

Review checklist

Reminder for reviewers

@tortmayr
Copy link
Contributor Author

tortmayr commented May 25, 2022 •
edited
Loading

@JonasHelming

@tortmayr tortmayr mentioned this pull request May 25, 2022
Closed
colin-grant-work
colin-grant-work approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JonasHelming JonasHelming merged commit 1a6c736 into eclipse-theia:master May 25, 2022
@JonasHelming JonasHelming added this to the 1.26.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

@JonasHelming JonasHelming JonasHelming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.

Large amount of uninformative output from IPC system
3 participants
@tortmayr @JonasHelming @colin-grant-work