core: bind UntitledResourceResolver in core
#11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates the binding of `UntitledResourceResolver` so that it is bound in `core` as it was moved around previously to be accessible outside of the plugin-system. Since the old binding was not updated the untitled functionality would break for apps that did not depend on plugin dependencies. Signed-off-by: vince-fugnitto <[email protected]>
colin-grant-work
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The commit updates the binding of
UntitledResourceResolverso that it is bound incoreas it was moved around previously to be accessible outside of the plugin-system. Since the old binding was not updated the untitled functionality would break for apps that did not depend on plugin dependencies (forum discussion)How to test
untitledbehavior still works well (new editorin the application).plugindependencies then thenew editorfunctionality should still work.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]