task: fix problem matcher failed when kind is file

[DanboDuan]

Signed-off-by: bob [email protected]

What it does

It will always fails when task problem matcher kind is file as this:

{
    "tasks":
    [
        {
            "command": "cat test.log",
            "label": "test",
            "problemMatcher":
            {
                "fileLocation": "absolute",
                "owner": "Test",
                "pattern":
                [
                    {
                        "file": 1,
                        "kind": "file",
                        "regexp": "^([^\\s].*)$"
                    },
                    {
                        "code": 5,
                        "loop": true,
                        "message": 4,
                        "regexp": "^\\s+(\\d+):(\\d+)\\s+(error|warning|info)\\s+(.+?)(?:\\s\\s+(.*))?$",
                        "severity": 3
                    }
                ]
            },
            "type": "shell"
        }
    ],
    "version": "2.0.0"
}

the test log should be

> [email protected] lint /home/test
> eslint .


/home/test/test-dir.js
  14:21  warning  Missing semicolon  semi
  15:23  warning  Missing semicolon  semi
  103:9  error  Parsing error: Unexpected token inte

/home/test/more-test.js
  13:9  error  Parsing error: Unexpected token 1000

✖ 3 problems (1 error 2 warnings)
  0 errors and 2 warnings potentially fixable with the `--fix` option.

this is the startStopMatcher2 case from packages/task/src/node/task-problem-collector.spec.ts, I just changes the kind from location to file.

the main cause is that the this.cachedProblemData.kind will always be undefined when cachedProblemData is created. just changes the not be undefined to be undefined

protected doOneLineMatch(line: string): boolean {
    if (this.activePattern) {
        const regexp = new RegExp(this.activePattern.regexp);
        const regexMatches = regexp.exec(line);
        if (regexMatches) {
            if (this.activePattern.kind !== undefined && this.cachedProblemData.kind !== undefined) {
                this.cachedProblemData.kind = this.activePattern.kind;
            }
            return this.fillProblemData(this.cachedProblemData, this.activePattern, regexMatches);
        }
    }
    return false;
}

How to test

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[DanboDuan]

@msujew @vince-fugnitto could you please help review this pr or ask someone else

[colin-grant-work]

Thanks for the contribution! The code is correct, and the tests pass. A couple of minor comments on the code itself, but with those minor changes, this will be good to go.

[DanboDuan]

Thanks for the contribution! The code is correct, and the tests pass. A couple of minor comments on the code itself, but with those minor changes, this will be good to go.

Thx！

[colin-grant-work]

Looks good to me. File type locations are now handled correctly. 👍

[DanboDuan]

Looks good to me. File type locations are now handled correctly. 👍

Thx. @vince-fugnitto @colin-grant-work could you please help merge this pr