Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chinese localization translation #11182

Merged

Conversation

zhaomenghuan
Copy link
Contributor

What it does

How to test

Review checklist

Reminder for reviewers

Signed-off-by: zhaomenghuan [email protected]

@zhaomenghuan zhaomenghuan force-pushed the feature/localization branch from 35e25f6 to 4677faa Compare May 20, 2022 15:37
@zhaomenghuan zhaomenghuan changed the title feat(core): Fix Chinese localization translation fix(core): Fix Chinese localization translation May 20, 2022
@zhaomenghuan zhaomenghuan changed the title fix(core): Fix Chinese localization translation Fix Chinese localization translation May 20, 2022
@zhaomenghuan zhaomenghuan force-pushed the feature/localization branch from 4677faa to 280f3a1 Compare May 20, 2022 15:55
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the extent I can judge, this is a vast improvement. Many thanks for the contribution! I have only a couple of comments below.

@msujew, in the case of the editor preference description translations, this touches translations of strings taken from Monaco and likely covered by newer versions of VSCode's translations. Even if we don't update our base nls.metadata.json when we update Monaco, might there be a way to incorporate a check of VSCode's translation repo when doing the automated translations so we don't end up with bad translations that we could have avoided?

"closeTabMain": "关闭主区域标签页",
"collapseAllTabs": "折叠所有标签页",
"collapseBottomPanel": "折叠底部面板",
"collapseTab": "折叠标签页",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the key is 'collapseTab', the English here is 'Collapse Side Panel'. Would it make sense to use a translation similar to 'Collapse Bottom Panel' above, something with '面板' rather than '标签页'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the key is 'collapseTab', the English here is 'Collapse Side Panel'. Would it make sense to use a translation similar to 'Collapse Bottom Panel' above, something with '面板' rather than '标签页'?

@colin-grant-work Thank you for your correction, I ignored the English description, I have modified it

"editorDecorationsEnabled": "在编辑器中显示git的装饰。",
"fetchPickRemote": "挑选一个遥控器来取物。",
"dropStashMessage": "存储删除成功。",
"editorDecorationsEnabled": "控制 Git 是否在打开编辑器视图中添加颜色和小标",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a translation of the description for the VSCode Git preference git.decorations.enabled, the English text of which is 'Controls whether Git contributes colors and badges to the Explorer and the Open Editors view.' However, the Theia text to be translated here is 'Show git decorations in the editor.' In particular, the Theia text does not mention 'open editors' (打开编辑器视图) or 'badges' (小标).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a translation of the description for the VSCode Git preference git.decorations.enabled, the English text of which is 'Controls whether Git contributes colors and badges to the Explorer and the Open Editors view.' However, the Theia text to be translated here is 'Show git decorations in the editor.' In particular, the Theia text does not mention 'open editors' (打开编辑器视图) or 'badges' (小标).

Original translation restored

@zhaomenghuan zhaomenghuan force-pushed the feature/localization branch from 280f3a1 to cdf1312 Compare May 23, 2022 11:18
@msujew
Copy link
Member

msujew commented May 23, 2022

might there be a way to incorporate a check of VSCode's translation repo when doing the automated translations so we don't end up with bad translations that we could have avoided?

@colin-grant-work Hm, maybe. I'm not too sure how difficult this would be. While we can always access the vscode-loc repo for this, it doesn't contain the English version of the text. So it becomes quite difficult to find the correct translation, since we don't have the correct keys (we create our own) and we can't search by the English text.

@colin-grant-work
Copy link
Contributor

it doesn't contain the English version of the text. So it becomes quite difficult to find the correct translation, since we don't have the correct keys (we create our own) and we can't search by the English text.

That does put us in a difficult spot. In any case, all of that is for later consideration. This PR looks good to go.

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 非常感谢你的贡献!

@colin-grant-work colin-grant-work merged commit edb2ef9 into eclipse-theia:master May 23, 2022
@colin-grant-work colin-grant-work added this to the 1.26.0 milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants