-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Chinese localization translation #11182
Fix Chinese localization translation #11182
Conversation
35e25f6
to
4677faa
Compare
4677faa
to
280f3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the extent I can judge, this is a vast improvement. Many thanks for the contribution! I have only a couple of comments below.
@msujew, in the case of the editor preference description translations, this touches translations of strings taken from Monaco and likely covered by newer versions of VSCode's translations. Even if we don't update our base nls.metadata.json
when we update Monaco, might there be a way to incorporate a check of VSCode's translation repo when doing the automated translations so we don't end up with bad translations that we could have avoided?
packages/core/i18n/nls.zh-cn.json
Outdated
"closeTabMain": "关闭主区域标签页", | ||
"collapseAllTabs": "折叠所有标签页", | ||
"collapseBottomPanel": "折叠底部面板", | ||
"collapseTab": "折叠标签页", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the key is 'collapseTab', the English here is 'Collapse Side Panel'. Would it make sense to use a translation similar to 'Collapse Bottom Panel' above, something with '面板' rather than '标签页'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the key is 'collapseTab', the English here is 'Collapse Side Panel'. Would it make sense to use a translation similar to 'Collapse Bottom Panel' above, something with '面板' rather than '标签页'?
@colin-grant-work Thank you for your correction, I ignored the English description, I have modified it
packages/core/i18n/nls.zh-cn.json
Outdated
"editorDecorationsEnabled": "在编辑器中显示git的装饰。", | ||
"fetchPickRemote": "挑选一个遥控器来取物。", | ||
"dropStashMessage": "存储删除成功。", | ||
"editorDecorationsEnabled": "控制 Git 是否在打开编辑器视图中添加颜色和小标", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a translation of the description for the VSCode Git preference git.decorations.enabled
, the English text of which is 'Controls whether Git contributes colors and badges to the Explorer and the Open Editors view.' However, the Theia text to be translated here is 'Show git decorations in the editor.' In particular, the Theia text does not mention 'open editors' (打开编辑器视图) or 'badges' (小标).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a translation of the description for the VSCode Git preference
git.decorations.enabled
, the English text of which is 'Controls whether Git contributes colors and badges to the Explorer and the Open Editors view.' However, the Theia text to be translated here is 'Show git decorations in the editor.' In particular, the Theia text does not mention 'open editors' (打开编辑器视图) or 'badges' (小标).
Original translation restored
280f3a1
to
cdf1312
Compare
Signed-off-by: zhaomenghuan <[email protected]>
@colin-grant-work Hm, maybe. I'm not too sure how difficult this would be. While we can always access the |
That does put us in a difficult spot. In any case, all of that is for later consideration. This PR looks good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 非常感谢你的贡献!
What it does
How to test
Review checklist
Reminder for reviewers
Signed-off-by: zhaomenghuan [email protected]