Replace Path.toString()
with fsPath()
#11180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #10830
Simply does as the commit says. Since we often display file system paths to the user, formatting them in the style of the backend operating system is often preferable. That's what
Path.fsPath()
does.How to test
You will need a Windows system to test the improved behavior.
Assert that the paths displayed in tooltips, messages, etc. are correctly formatted for the actual backend system:
Windows Exec
with its browse functionality)Review checklist
Reminder for reviewers