Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Path.toString() with fsPath() #11180

Merged
merged 1 commit into from
May 25, 2022
Merged

Replace Path.toString() with fsPath() #11180

merged 1 commit into from
May 25, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented May 20, 2022

What it does

Closes #10830

Simply does as the commit says. Since we often display file system paths to the user, formatting them in the style of the backend operating system is often preferable. That's what Path.fsPath() does.

How to test

You will need a Windows system to test the improved behavior.

Assert that the paths displayed in tooltips, messages, etc. are correctly formatted for the actual backend system:

  • Search in workspace view
  • Editor tabs
  • Open Editors view
  • Navigator view
  • Problem view
  • Preferences (such as the Windows Exec with its browse functionality)
  • Property view (for files)

Review checklist

Reminder for reviewers

@msujew msujew added filesystem issues related to the filesystem OS/Windows issues related to the Windows OS labels May 20, 2022
@msujew msujew force-pushed the msujew/fix-uri-path branch 3 times, most recently from 5d7a389 to bec9d0b Compare May 20, 2022 16:18
@msujew msujew force-pushed the msujew/fix-uri-path branch from bec9d0b to 9255d81 Compare May 20, 2022 16:43
@colin-grant-work colin-grant-work self-requested a review May 23, 2022 16:37
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't observe any regressions, and the inter-platform functionality works nicely. 👍

@msujew msujew merged commit 9ec8835 into master May 25, 2022
@msujew msujew deleted the msujew/fix-uri-path branch May 25, 2022 11:49
@github-actions github-actions bot added this to the 1.26.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem issues related to the filesystem OS/Windows issues related to the Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect usage of URI#path.toString() on Windows
2 participants