Use correct path for call hierarchy #11178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
vscode
colin-grant-work
approved these changes
May 19, 2022
JonasHelming
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes the call hierarchy view for Windows. See the discussion in #11011 for more infos.
The culprit seems to be the
URI.fsPathcall. When calling it on Windows, we receive an invalid URI back (containing backslashes, etc.). Using the simplepathvariable enables correct revival of the URI on the plugin side.How to test
Open the call hierarchy on different OS configurations:
It should open correctly without any errors.
Review checklist
Reminder for reviewers