Update Windows Build instructions #11165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmaeder
requested changes
May 17, 2022
jfaltermeier
force-pushed
the
jf/windowsBuild
branch
from
02bb62c to
6c4e989
Compare
vince-fugnitto
added
OS/Windows
* link to node-gyp documentation for manual up to date instruction * based on lessons learned from blueprint: * eclipse-theia/theia-ide#202 * eclipse-theia/theia-ide#208 Signed-off-by: Johannes Faltermeier <[email protected]> Co-authored-by: Thomas Mäder <[email protected]>
jfaltermeier
force-pushed
the
jf/windowsBuild
branch
from
c547961 to
07efe96
Compare
tsmaeder
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Updates the builds instructions for windows based on the lessons learned from blueprint (visual studio 2017 and python 3.6+).
Also adds a link to the
node-gypdocumentation.Blueprint Issues:
Review checklist
Reminder for reviewers