Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support traversing the editor navigation history through mouse buttons #11163

Merged
merged 2 commits into from
May 19, 2022

Conversation

martin-fleck-at
Copy link
Contributor

What it does

How to test

  • Open application in browser or electron. If you use the browser you can open your application through a link so you don't have any history to begin with, otherwise the window history navigation will navigate you away from your Theia app. This is also the behavior in the GitHub web editor.
  • Navigate within a file or between files.
  • Click your mouse button 4 and 5 to navigate between your previous navigations.

Review checklist

Reminder for reviewers

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a mouse that would let me test this as it's meant to function, but some minor comments below.

Co-authored-by: colin-grant-work <[email protected]>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although I'm having a bit of trouble getting this to work in the browser (as my browsers try to leave the back when back-navigating), it works perfectly in Electron.

  • Back-navigation works correctly using button 3
  • Front-navigation works correctly using button 4
  • Other mouse buttons continue to work as expected

@JonasHelming JonasHelming merged commit c4e55ec into eclipse-theia:master May 19, 2022
@JonasHelming JonasHelming added this to the 1.26.0 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support traversing the editor navigation history through mouse buttons
4 participants