Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in function Transaction::disposeWhenDone #11130

Merged
merged 2 commits into from
May 11, 2022

Conversation

educphi
Copy link
Contributor

@educphi educphi commented May 11, 2022

What it does

Fixes #11126

The commit fixes a typo in a comment, contained in function Transaction::disposeWhenDone.

How to test

N/A

Review checklist

Reminder for reviewers

Signed-off-by: Philippe Ducas [email protected]

@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label May 11, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enqueued is better 👍

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@colin-grant-work colin-grant-work merged commit fd14c0b into eclipse-theia:master May 11, 2022
@vince-fugnitto vince-fugnitto added this to the 1.26.0 milestone May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in comment : Preference Transaction Manager
3 participants