core: respect visible menuBarVisibility for fullscreen
#11119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It looks like the combination of custom title bar and classic menu bar visibility give an unexpected result.
| Preference | Expectation | Behavior |
|---|---|---|
window.titleBarStyle = native && window.menuBarVisibility = classic |
toggling full-screen (F11) should hide the main menu | Hidden |
window.titleBarStyle = native && window.menuBarVisibility = hidden |
toggling full-screen (F11) should hide the main menu | Hidden |
window.titleBarStyle = native && window.menuBarVisibility = compact |
toggling full-screen (F11) should hide the main menu | Compact |
window.titleBarStyle = native && window.menuBarVisibility = visible |
toggling full-screen (F11) should show the main menu | Visible |
window.titleBarStyle = custom && window.menuBarVisibility = classic |
toggling full-screen (F11) should hide the main menu | Visible ❌ |
window.titleBarStyle = custom && window.menuBarVisibility = hidden |
toggling full-screen (F11) should hide the main menu | Hidden |
window.titleBarStyle = custom && window.menuBarVisibility = compact |
toggling full-screen (F11) should hide the main menu | Compact |
window.titleBarStyle = custom && window.menuBarVisibility = visible |
toggling full-screen (F11) should show the main menu | Visible |
vince-fugnitto
force-pushed
the
vf/menu-fullscreen
branch
from
07e4664 to
1ce2463
Compare
|
@colin-grant-work I've updated the pull-request so that it properly handles both |
The commit updates the handling of `toggle full screen` to respect `menuBarVisibility` properly. If the `menuBarVisibility` is set to `visible` the menu should be visible when the app is in fullscreen. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/menu-fullscreen
branch
from
1ce2463 to
a4c8f2e
Compare
colin-grant-work
approved these changes
May 13, 2022
|
@msujew I just wanted to know if you had any feedback given you touched the menus in the past :) |
|
I'll try to merge tomorrow if there are no objections. |
msujew
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10077.
Closes #10213.
The pull-request updates the handling of "toggle full screen" (electron) to properly respect the preference
window.menuBarVisibility. If the preference is set tovisiblethen the menu should remain visible on fullscreen for both thecustomandnativemain-menus. The change also includes a listener to properly update the main-menu when in full-screen.How to test
toggling behavior:
window.titleBarStyletonativewindow.menuBarVisibility, confirm the behaviornativeclassicnativehiddennativecompactnativevisiblecustomclassiccustomhiddencustomcompactcustomvisibleThe behavior of each option should be similar to what is experienced in vscode.
full-screen behavior:
customandnativetitlebar styles that:menuBarVisibilitywill properly update the visibilityvisibleshould display the menu in full-screenReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]