Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Monaco keybindings on keybinding change #11101

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #8769, closes #8776

How to test

  1. Change keybindings for commands relevant in Monaco. (e.g. for command editor.action.deleteLines).
  2. Ensure that those keybindings take effect in an editor.
  3. Change keybinding for acceptRenameInput.
  4. Open an editor and start a rename symbol interaction.
  5. Observe that the new acceptRenameInput shortcut is displayed as part of the input, and that that key sequence in fact accepts the rename.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added keybindings issues related to keybindings monaco issues related to monaco labels May 3, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work as expected, and are more straightforward thanks to the monaco upgrade 👍

  • keybindings for commands like delete line work well in the editor
  • updating acceptRenameInput works for both the rendering (F2) and applying the keybinding
  • updating acceptRenameInputPreview works for both the rendering (F2) and applying the keybinding

@colin-grant-work colin-grant-work merged commit eb0930a into eclipse-theia:master May 4, 2022
@colin-grant-work colin-grant-work deleted the bugfix/transmit-keybindings-to-monaco branch May 4, 2022 23:08
@colin-grant-work colin-grant-work added this to the 1.26.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User keybindings are not propagated into vscode editor
2 participants