[MacOS] Remove window focus listener on unload #11075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
On
master
in Electron on MacOS, we attach a listener for window focus and never release it. As a consequence, if the user refreshes the Electron window, they will see logs indicating that a listener was called an a renderer that has been released. This PR removes that message by ensuring that we remove the listener when the window unloads.How to test
Review checklist
Reminder for reviewers