Make preference node renderers more robust against null
values
#11074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
A number of preferences use
null
as a default even if that is not among their declared values. As a consequence, it is possible for a preference renderer to encounter a null value when another value type is expected.How to test
master
, you will see a message about inability to readtoString
ofnull
and the layout may fail to be restored.toString
ofnull
and the layout should successfully be restored. The preferencehtml.format.maxPreserveNewLines
should show an empty input box, unless you have set a numerical value for it.Review checklist
Reminder for reviewers