Guarantee that QuickPickService.showQuickPick
resolves on hide
#11068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11067 by ensuring that the promise returned by
QuickPickService.showQuickPick
will be resolved by modifyingMonacoQuickInputService
to resolveundefined
after the quick pick is hidden. If the promise has already been resolved, the second resolution will have no effect, and if it hasn't, it will be resolved withundefined
.How to test
Test QuickPickService.show
.undefined
.Review checklist
Reminder for reviewers