-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open new, multi-root workspace from CLI #11034
Open new, multi-root workspace from CLI #11034
Conversation
9d1b95a
to
afedf8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the following works well for me on linux:
yarn electron start
without a workspace will open the previously opened workspaceyarn electron start ${folder}
will open the application with the folder as a workspaceyarn electron start ${invalid-folder}
will open the application without a workspaceyarn electron start ${folder-1} ${folder-2}
will open the application with a multi-root workspace with the supplied folder rootsyarn electron start ${folder-1} ${folder-2} ${invalid-folder}
will open the application with a multi-root workspace with the supplied folder roots omitting the invalid one
@msujew, would you be willing to weigh in on the URI handling in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed some issues on Windows with this. I checked that it works correctly with the suggestion applied 👍
You will need to rebase in order to use Path.fsPath()
.
afedf8d
to
fb88fa4
Compare
10ec751
to
3f0b264
Compare
@msujew, many thanks! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colin-grant-work You're welcome :)
After the latest changes everything works well for me!
What it does
This PR implements the ability to open a multi-root workspace by entering multiple folders on the command line.
How to test
Decisions:
Review checklist
Reminder for reviewers