Narrow typing of Saveable.createSnapshot #11032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #11031.
In the Monaco uplift, the return of
MonacoEditorModel.createSnapshot
was changed, but its effect on theSaveable
system was not detected because the return ofSaveable.createSnapshot
was typed asobject
. This PR narrows that typing so that callers of the function have some idea what to expect, and deviations from those expectations can be caught.How to test
Save as
on both editorsReview checklist
Reminder for reviewers