Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11021 Add API documentation for property-view and selection-service #11022

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Apr 13, 2022

What it does

  • Add missing API documentation for interfaces and classes in the property-view package
  • Add missing API documentation for the Theia selection-service

Resolves #11021

Contributed on behalf of STMicroelectronics.

Signed-off-by: Nina Doschek [email protected]

How to test

--

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added documentation issues related to documentation property-view issues related to the property-view extension labels Apr 13, 2022
@ndoschek
Copy link
Contributor Author

Thank you for your review @vince-fugnitto! I addressed your comments - could you have another look what you think about it? Thanks!

…tion-service

- Add missing API documentation for interfaces and classes in the property-view package
- Add missing API documentation for the Theia selection-service

Resolves eclipse-theia#11021

Contributed on behalf of STMicroelectronics.

Signed-off-by: Nina Doschek <[email protected]>
@ndoschek
Copy link
Contributor Author

@vince-fugnitto I squashed my commits and rebased to master

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonasHelming JonasHelming merged commit 1972f21 into eclipse-theia:master Apr 19, 2022
@JonasHelming JonasHelming added this to the 1.25.0 milestone Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation property-view issues related to the property-view extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API documentation for property-view and selection-service
3 participants