Ensure that old values aren't cached inappropriately #10965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10959
Fixes #10865
Previously, the caching mechanism in
ValidatedPreferenceProxy
could mistakenly retain cached values for language overrides. This PR ensures that the cache is maintained only once the proxy subscribes to preference events and that it is updated for all overrides in case of a preference change.How to test
editor.minimap.enabled
preference. It should immediately take effect in open editors (in all languages) and apply correctly to new editors.Review checklist
Reminder for reviewers