Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: add SourceFixAll declaration to CodeActionKind #10921

Merged
merged 1 commit into from
Mar 28, 2022
Merged

plugin: add SourceFixAll declaration to CodeActionKind #10921

merged 1 commit into from
Mar 28, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Mar 24, 2022 •
edited
Loading

What it does

Fixes: #9991.

The pull-request adds the SourceFillAll declaration for CodeActionKind.

The action is already supported in our codebase, but was never added to our theia.d.ts file which meant it was marked as unsupported:

theia/packages/plugin-ext/src/plugin/types-impl.ts

Line 1204 in acd6f57

public static readonly SourceFixAll = CodeActionKind.Source.append('fixAll');

How to test

There should not be a change in functionality, the build should successfully pass.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto
plugin: add SourceFixAll declaration
d5c6d7c 
The commit adds the `SourceFixAll` declaration to the framework's VS
Code API so it is marked as supported in our compatibility report.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Mar 24, 2022
colin-grant-work
colin-grant-work approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the corresponding field is present on the implementation of the CodeActionKind class.

@JonasHelming
Copy link
Contributor

@vince-fugnitto : Does this fix #9991?

@vince-fugnitto vince-fugnitto merged commit 003aeb9 into master Mar 28, 2022
@vince-fugnitto vince-fugnitto deleted the vf/sourceFixAll branch March 28, 2022 16:08
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Add CodeActionKind#SourceFixAll
3 participants
@vince-fugnitto @JonasHelming @colin-grant-work