Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add replace method support for OutputChannel #10915

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #10914.

The pull-request adds support for the replace method for the OutputChannel VS Code API which replaces all content in a given channel with the new value.

How to test

  1. include the following test plugin vs-output-0.0.1.zip
  2. start the application
  3. execute the command Output: Part 1
  4. open the output-view, and select the vs-output channel
  5. confirm that the view has output
  6. execute the command Output: Part 2
  7. confirm that the content is replaced

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit adds support for the `replace` method in the `OutputChannel`
API to replace any previous content in the given channel with the new
value.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Mar 23, 2022
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and works as described. 👍

@vince-fugnitto vince-fugnitto merged commit b1bd7bd into master Mar 25, 2022
@vince-fugnitto vince-fugnitto deleted the vf/output-replace branch March 25, 2022 12:58
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin: support replace method for OutputChannel
2 participants