Allow override of provider -> context #10911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
added
preferences
…minor/transaction-indirection
colin-grant-work
force-pushed
the
minor/transaction-indirection
branch
from
4f479ec
to
1c3b5b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR allows extenders of the
AbstractResourcePreferenceProviderclass to modify how their child class converts itself to aPreferenceContextfor the consumption of aPreferenceTransactionto allow for indirection within the confines of Theia'sPreferenceScopesystem.How to test
This should not change the behavior of the application in any way.
Review checklist
Reminder for reviewers